dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

fix: Attempt to optimize OntologyInferencer (DEV-4063)

Open siers opened this issue 1 year ago • 5 comments

Pull Request Checklist

Let's test this on dev!

Task Description/Number

Issue Number: DEV-

PR Type

  • [ ] build/chore: maintenance tasks (no production code change)
  • [ ] docs: documentation changes (no production code change)
  • [ ] feat: represents new features
  • [ ] fix: represents bug fixes
  • [ ] perf: performance improvements
  • [ ] refactor: represents production code refactoring
  • [ ] test: adding or refactoring tests (no production code change)
  • [ ] deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • [ ] Tests for the changes have been added
  • [ ] Docs have been added / updated

Does this PR introduce a breaking change?

  • [ ] Yes

siers avatar Oct 25 '24 12:10 siers

@BalduinLandolt Still just hoping, I was really trying to get the local version working with the dev db, but to no avail.

I would like to try this out on dev therefore.

siers avatar Oct 30 '24 14:10 siers

@BalduinLandolt I removed the - // Expand using rdfs:subPropertyOf*. lines, since they no longer seem relevant.

siers avatar Oct 30 '24 14:10 siers

@BalduinLandolt Still just hoping, I was really trying to get the local version working with the dev db, but to no avail.

I would like to try this out on dev therefore.

Good enough for me, thanks

BalduinLandolt avatar Oct 30 '24 14:10 BalduinLandolt

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 17.89%. Comparing base (6ebe8e7) to head (1586aab). Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
...h/gravsearch/transformers/OntologyInferencer.scala 38.88% 11 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3402       +/-   ##
===========================================
- Coverage   83.04%   17.89%   -65.15%     
===========================================
  Files         290      304       +14     
  Lines       23087    22758      -329     
===========================================
- Hits        19172     4073    -15099     
- Misses       3915    18685    +14770     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 30 '24 14:10 codecov[bot]

@seakayone I think your previous "change requested" might be blocking this.

siers avatar Oct 31 '24 13:10 siers