dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

fix: Exclude special characters in searchbylabel search (DEV-1446)

Open irinaschubert opened this issue 2 years ago • 1 comments

Issue Number: DEV-1446

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix: represents bug fixes
  • [ ] Refactor: represents production code refactoring
  • [ ] Feature: represents a new feature
  • [ ] Documentation: documentation changes (no production code change)
  • [ ] Chore: maintenance tasks (no production code change)
  • [ ] Style: styles updates (no production code change)
  • [ ] Test: all about tests: adding, refactoring tests (no production code change)
  • [ ] Other... Please describe:

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Does this PR change client-test-data?

  • [ ] Yes (don't forget to update the JS-LIB team about the change)
  • [ ] No

Other information

irinaschubert avatar Oct 26 '22 15:10 irinaschubert

Codecov Report

Base: 86.85% // Head: 86.99% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (b79723d) compared to base (c5c98ce). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
+ Coverage   86.85%   86.99%   +0.13%     
==========================================
  Files         241      242       +1     
  Lines       27967    28066      +99     
==========================================
+ Hits        24292    24415     +123     
+ Misses       3675     3651      -24     
Impacted Files Coverage Δ
...c/main/scala/org/knora/webapi/core/AppServer.scala 89.55% <ø> (ø)
...ebapi/instrumentation/InstrumentationSupport.scala 100.00% <ø> (ø)
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 94.18% <100.00%> (-0.14%) :arrow_down:
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 89.85% <100.00%> (+5.79%) :arrow_up:
.../org/knora/webapi/messages/OntologyConstants.scala 99.62% <100.00%> (+<0.01%) :arrow_up:
...la/org/knora/webapi/messages/StringFormatter.scala 90.18% <100.00%> (+0.01%) :arrow_up:
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 65.38% <0.00%> (-3.85%) :arrow_down:
...n/scala/org/knora/webapi/routing/HealthRoute.scala 69.81% <0.00%> (-1.89%) :arrow_down:
...r/permissionsmessages/PermissionsMessagesADM.scala 86.39% <0.00%> (-0.32%) :arrow_down:
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) :arrow_down:
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 27 '22 16:10 codecov[bot]