hippomocks icon indicating copy to clipboard operation
hippomocks copied to clipboard

cpp11 branch make install is broken

Open rianquinn opened this issue 7 years ago • 7 comments

Make install does not install any of the needed headers.

/home/user/bfprefix/include/hippomocks.h:100:28: fatal error: detail/replace.h: No such file or directory
#include "detail/replace.h"

rianquinn avatar Apr 11 '17 00:04 rianquinn

This is what I think the install code for CMake should look like

install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/hippomocks.h DESTINATION include)
install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/comsupport.h DESTINATION include)
install(DIRECTORY ${PROJECT_SOURCE_DIR}/HippoMocks/detail DESTINATION include)

rianquinn avatar Apr 11 '17 00:04 rianquinn

It needs the opposite fix actually; it should be available as a single header file again.

dascandy avatar Apr 12 '17 14:04 dascandy

@dascandy one way to fix that if your trying to keep things clean would be to use CMake Install to merge the files for you. I'm pretty sure CMake can do that

rianquinn avatar Apr 12 '17 14:04 rianquinn

Yes I can check this for next release

rzr avatar Jan 31 '18 12:01 rzr

Any status on this?

rianquinn avatar Feb 16 '18 15:02 rianquinn

yes cmake has install feature

What is the plan for next release ? should it only support cmake or both ?

Related: https://github.com/dascandy/hippomocks/pull/86

rzr avatar Feb 16 '18 15:02 rzr

@rianquinn I might as well fix this issue while watching your CppCon talk. I had no idea you were there presenting it.

dascandy avatar Mar 01 '18 09:03 dascandy