stashvision icon indicating copy to clipboard operation
stashvision copied to clipboard

Highlighted recipe missing a ring

Open thebeast792 opened this issue 5 years ago • 5 comments

I noticed that when I was using this tool at the beginning of the league, the highlights would sometimes be missing a ring (maybe 50% of the time?). It's possible that I somehow kept missing the highlight of the ring in my quad stash but I'm fairly certain this happened sometimes. I'm busy playing atm so cannot provide logs right now, but it shouldn't be too hard to test it and reproduce it. Just load a quad stash tab with a few recipes.

thebeast792 avatar Jul 03 '20 15:07 thebeast792

I tried testing it again but wasn't able to reproduce it. Please keep an eye out for it.

thebeast792 avatar Aug 17 '20 21:08 thebeast792

The issue happened again. It keeps missing one ring highlight when you ask it to show the recipe. I THINK it has to do with the regal recipe portions (ilvl 75+) items...that change probably added this bug.

Also, could you please have an option to disable logging or to truncate the log file? The log file grows way really quickly and would like to limit that significantly.

thebeast792 avatar Sep 20 '20 15:09 thebeast792

I have very little experience with this script so far. Running from latest code from the master branch. The script only highlighted 1 1h weapon for me.

Edit: Highlighting has been working really well after writing this comment...

EirikAskheim avatar Sep 22 '20 11:09 EirikAskheim

are you still seeing the issue with 75+ items?

darvid avatar Sep 24 '20 15:09 darvid

I have not been able to figure out why it happens sometimes. I've been restarting stashvision a bit between hand ins and sometimes I have the "one-ring-issue" multiple times on a quad-vendor-binge and sometimes no issues at all.

I can see if ilvl matters. But now I'm getting into red maps so will see how much more chaos recipe I will do :-)

EirikAskheim avatar Sep 25 '20 07:09 EirikAskheim