dart icon indicating copy to clipboard operation
dart copied to clipboard

Consider being consistent in dirty flag names

Open jslee02 opened this issue 8 years ago • 3 comments

We're using two naming convention for the dirty flags of the auto updating kinematics: mNeedXUpdate and mIsXDirty. It would be good to have one convention.

I don't have a strong preference here. To me, mNeedXUpdate sounds more natural while mIsXDirty is shorter.

jslee02 avatar Nov 03 '16 13:11 jslee02

Now I'm inclined to using mIsXDirty because it seems to be more frequently used in practice. Please let me know if someone has a strong preference here.

jslee02 avatar Jan 12 '17 15:01 jslee02

I have a slight preference for naming boolean variables with the Is prefix. I find it is easier to find boolean variables semantically if they are all IsX and IsY.

psigen avatar Jan 12 '17 15:01 psigen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 13 '18 17:02 stale[bot]