typed_data icon indicating copy to clipboard operation
typed_data copied to clipboard

Allow upcoming package:collection version 2.x

Open oprypin opened this issue 1 year ago • 4 comments

There will not be a breaking change in package:collection that concerns this package, but currently due to a circular dependency it's not even possible to bump said package's version to 2.0.

  • See the CI failure in https://github.com/dart-lang/collection/pull/331
$ dart pub get
Resolving dependencies...
Because test >=1.16.0 depends on typed_data ^1.3.0 which depends on collection ^1.15.0, test >=1.16.0 requires collection ^1.15.0.
So, because collection depends on test ^1.16.0 and collection is 2.0.0-wip, version solving failed.

  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

oprypin avatar Feb 05 '24 09:02 oprypin

What's the story here?

kevmoo avatar Apr 17 '24 20:04 kevmoo

There will not be a breaking change in package:collection that concerns this package, but currently due to a circular dependency it's not even possible to bump said package's version to 2.0.

  • See the CI failure in https://github.com/dart-lang/collection/pull/331
$ dart pub get
Resolving dependencies...
Because test >=1.16.0 depends on typed_data ^1.3.0 which depends on collection ^1.15.0, test >=1.16.0 requires collection ^1.15.0.
So, because collection depends on test ^1.16.0 and collection is 2.0.0-wip, version solving failed.

oprypin avatar Apr 17 '24 20:04 oprypin

collection only depends on test through a dev_dependency; it would be possible to do dependency_override of typed_data in package collection's pubspec, which would allow its CI to complete. That would mean we wouldn't have to proactively publish a version of typed_data which allows for an unpublished major version of collection.

devoncarew avatar Apr 17 '24 20:04 devoncarew

Thanks @devoncarew. But maybe this is still simpler - why not make a proactive release? A release that increases the version range would have to be done right away anyway.

oprypin avatar Apr 18 '24 09:04 oprypin