tools icon indicating copy to clipboard operation
tools copied to clipboard

Handle tag_pattern in git dependencies

Open sigurdm opened this issue 3 months ago • 3 comments

Starts handling version constraint for git dependencies.

#2155

sigurdm avatar Sep 08 '25 13:09 sigurdm

PR Health

Breaking changes :warning:
Package Change Current Version New Version Needed Version Looking good?
pubspec_parse Breaking 1.5.0 1.6.0-wip 2.0.0
Got "1.6.0-wip" expected >= "2.0.0" (breaking changes)
:warning:

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry :heavy_check_mark:
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage :warning:
File Coverage
pkgs/pubspec_parse/lib/src/dependency.dart :broken_heart: 71 % :arrow_down: 1 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks :heavy_check_mark:

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers :heavy_check_mark:
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

github-actions[bot] avatar Sep 08 '25 13:09 github-actions[bot]

Can you edit the first comment on this PR with some detail about how the code is changing? We can use that as the commit message when we merge.

natebosch avatar Sep 16 '25 16:09 natebosch

Hi, are there any updates on this PR? Would be great if this could be be made available any time soon. Thanks for your work!

FritzMatthaeus avatar Nov 11 '25 07:11 FritzMatthaeus

@sigurdm any plans to land this?

mosuem avatar Dec 12 '25 14:12 mosuem

Thanks for pinning

I got concerned that this is technically breaking the interface.

We probably need a more stupid approach.

Also I'm not sure that pubspec_parse is really the right thing to do - in most instances pub should really be the one to parse pubspecs.

Given all that, I'll close this for now. I don't really have the resources to pursue this now.

sigurdm avatar Dec 12 '25 14:12 sigurdm