tools icon indicating copy to clipboard operation
tools copied to clipboard

regenerate the mime tables from apache httpd; general refactorings

Open devoncarew opened this issue 9 months ago • 2 comments

(note that this isn't intended to land - more to discuss potential changes)

Regenerate the mime tables from the apache httpd mapping and other general refactorings:

  • regenerate the mime tables from the list maintained by the apache httpd project; generate the tables into lib/src/mime_tables.g.dart
  • change the magic numbers to use string hex values for the header bytes instead of list literals (this makes the code more terse)
  • consolidate several library public symbols into lib/src/mime.dart
  • make MimeTypeResolver have a similar API to the current two top level library symbols - lookupMimeType() and extensionFromMime()

I think instead of looking to make the top-level lookupMimeType() and extensionFromMime() methods something you can add mime types to, we want to have everything accessed through a mime registry, and by default provide a global instance of that. The registry could be configurable at construction time.

MimeTypeResolver is somewhat similar to that, except that you can mutate it after construction. If we were to use it as our mime registry, the global instance would be mutable, which seems less desirable.

Related to https://github.com/dart-lang/tools/issues/2028; cc @lrhn.

devoncarew avatar Mar 16 '25 23:03 devoncarew

Package publishing

Package Version Status Publish tag (post-merge)
package:bazel_worker 1.1.3-wip WIP (no publish necessary)
package:benchmark_harness 2.3.1 already published at pub.dev
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.4.2 already published at pub.dev
package:clock 1.1.2 already published at pub.dev
package:code_builder 4.10.1 already published at pub.dev
package:coverage 1.12.0-wip WIP (no publish necessary)
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.5+1 ready to publish html-v0.15.5+1
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 3.0.3 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:package_config 2.2.0 already published at pub.dev
package:pool 1.5.2-wip WIP (no publish necessary)
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.5.0 already published at pub.dev
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.7 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.2.3 already published at pub.dev
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 7.0.2 ready to publish unified_analytics-v7.0.2
package:watcher 1.1.1 already published at pub.dev
package:yaml 3.1.3 already published at pub.dev
package:yaml_edit 2.2.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] avatar Mar 16 '25 23:03 github-actions[bot]

PR Health

Breaking changes :warning:
Package Change Current Version New Version Needed Version Looking good?
mime Breaking 2.0.0 2.0.0 3.0.0
Got "2.0.0" expected >= "3.0.0" (breaking changes)
:warning:

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry :exclamation:
Package Changed Files
package:mime pkgs/mime/lib/mime.dart
pkgs/mime/lib/src/extension.dart
pkgs/mime/lib/src/magic_number.dart
pkgs/mime/lib/src/magic_numbers.dart
pkgs/mime/lib/src/mime.dart
pkgs/mime/lib/src/mime_shared.dart
pkgs/mime/lib/src/mime_tables.g.dart
pkgs/mime/lib/src/mime_type.dart
pkgs/mime/lib/src/multipart_stream.dart
pkgs/mime/lib/src/multipart_transformer.dart
pkgs/mime/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage :warning:
File Coverage
pkgs/mime/lib/mime.dart :broken_heart: Not covered
pkgs/mime/lib/src/magic_numbers.dart :green_heart: 100 %
pkgs/mime/lib/src/mime.dart :green_heart: 83 %
pkgs/mime/lib/src/mime_shared.dart :green_heart: 33 %
pkgs/mime/lib/src/mime_type.dart :broken_heart: 76 % :arrow_down: 15 %
pkgs/mime/lib/src/multipart_stream.dart :green_heart: 89 %
pkgs/mime/lib/src/multipart_transformer.dart :green_heart: 100 %
pkgs/mime/tool/generate_markdown.dart :broken_heart: Not covered
pkgs/mime/tool/update_media_types.dart :broken_heart: Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks :heavy_check_mark:

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers :heavy_check_mark:
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/coverage/test/collect_coverage_config_test.dart
pkgs/coverage/test/config_file_locator_test.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

github-actions[bot] avatar Mar 16 '25 23:03 github-actions[bot]

@devoncarew is there still intention to land this? Or is this superseded by #2063 ?

mosuem avatar Oct 07 '25 12:10 mosuem

Yes - this PR was more exploratory.

devoncarew avatar Oct 07 '25 17:10 devoncarew