tools icon indicating copy to clipboard operation
tools copied to clipboard

CI is failing

Open mosuem opened this issue 11 months ago • 5 comments

See https://github.com/dart-lang/tools/actions/runs/12969601332, specifically test/sse_test.dart: SSE disconnects when navigating away (failed).

cc @elliette

mosuem avatar Jan 27 '25 07:01 mosuem

FYI @bkonyi who now owns package:sse

elliette avatar Jan 28 '25 00:01 elliette

FYI @bkonyi who now owns package:sse

TIL 😅

Is this failing flakily? The test looks like it could have a race condition since there's no delay between navigating to a different page and checking the connection count.

bkonyi avatar Jan 28 '25 15:01 bkonyi

Is this failing flakily?

I haven't checked - just saw the scheduled run failing.

mosuem avatar Jan 28 '25 15:01 mosuem

I re-ran the failing checks and it's still failing, so it might not be flaky.

@jyameo can you take a look when you have a chance? At the very least, it might be worth skipping this test temporarily if we don't have time to fix it right now.

bkonyi avatar Jan 28 '25 16:01 bkonyi

I took a look at the issue, and my hunch is that the Chromedriver version has been updated, and possibly the newer versions don’t have the same behavior as the older ones. To unblock progress, I’ll go ahead and skip the test for now to get the CI green. I’ll revisit this later and investigate the root cause further.

CC @bkonyi

jyameo avatar Jan 28 '25 19:01 jyameo