site-www icon indicating copy to clipboard operation
site-www copied to clipboard

yellow is not a primary colour

Open dmcg opened this issue 1 year ago • 2 comments

Changed yellow to green, as yellow is not a primary color, so the example is wrong

dmcg avatar Oct 24 '24 15:10 dmcg

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 24 '24 15:10 google-cla[bot]

I signed the CLA but nothing is happening

dmcg avatar Oct 24 '24 16:10 dmcg

I had to look it up, but...

image

Closing this, but for next time: looks like your CLA was accepted but the check that was failing was "Check if code excerpts are up to date". If you look at line 192 above the line you changed, there's a path to a corresponding dart file that needs to change along with the example in the markdown (this section in the repo readme has more info)

Thanks!

MaryaBelanger avatar Oct 29 '24 19:10 MaryaBelanger

Maybe this is elitist, but I'm afraid that yellow offends me, and doesn't sit well in technical documentation.

https://en.wikipedia.org/wiki/Primary_color

Red, yellow and blue are also commonly taught as primary colours, despite some criticism due to its lack of scientific basis.

dmcg avatar Oct 30 '24 12:10 dmcg