site-www icon indicating copy to clipboard operation
site-www copied to clipboard

Add code excerpts to new type promotion failures

Open MaryaBelanger opened this issue 2 years ago • 2 comments
trafficstars

Excerpts added in #5246

Fixes #5350

MaryaBelanger avatar Nov 17 '23 18:11 MaryaBelanger

I'm still not sure how to implement the excerpts for the {:.bad} examples, tbd. Maybe the file just has a bunch of ignore_for_file conditions?

I know there's a way to print the actual error from the excerpts too (I think the Fixing common type problems page does it), so tbd on that too.

MaryaBelanger avatar Nov 18 '23 00:11 MaryaBelanger

Visit the preview URL for this PR (updated for commit f722e2c7841017e05f22f94df7c26412e7a48637):

https://dart-dev--pr5359-promo-code-exc-lmxwqb8m.web.app

dart-github-bot avatar Feb 04 '24 21:02 dart-github-bot

@MaryaBelanger : Once you get this PR updated, I'll take another look.

atsansone avatar Jun 03 '24 16:06 atsansone

@MaryaBelanger : This was last touched by you in 2023. Do you think you can come back to this or should someone else pick it up?

atsansone avatar Jun 17 '24 21:06 atsansone

I took this one over and will try to get back to it this week.

parlough avatar Jun 17 '24 23:06 parlough