site-www
site-www copied to clipboard
dart-lang
Replace or simplify font awesome usage
Describe the problem
After the infrastructure update we use JS for integrating Font Awesome. Even using brotli it is still 436 kB and by far the largest thing on the website for just a few icons.
Expected fix
Manually include the icons we need perhaps as a font or switch to material icons and/or SVGs.
Additional context
No response
Hi @hrk2023, thanks so much for reaching out! I haven't had a chance to decide the best direction to approach solving this problem. I'm happy to hear your thoughts and help you work on any changes.
We don't use a lot of font awesome icons, so I'm thinking it would be best if we could switch most uses to similar Material Icons. A few we use in one spot we can consider finding an appropriately licensed SVG.
One good first step would be to switch the uses of the font awesome external link icon to the material icon one as we already use the material icon version elsewhere. For example they are used in the sidebar here:
How about starting with that and letting me know if you need any guidance or help?
Ok then I will start with replacing the font awesome links with appropriate material icons.
@parlough I made a PR #151 in the dart-lang/site-shared repo regarding this issue. Please check it out and after that's done I can create a PR for some CSS changes required for the material icons.
@parlough I made a PR #3830 in dart-lang/site-www repo to add some css styles for material icons added in dart-lang/site-shared.
Closing in favor of https://github.com/dart-lang/site-www/issues/4278 to consolidate the work.