site-www icon indicating copy to clipboard operation
site-www copied to clipboard

Don't commit compiled dartpad_picker JS

Open chalin opened this issue 5 years ago • 2 comments

Followup to #1887 and #1914.

We current commit the compiled JS version of dartpad_picker. We should instead generate it when the site is built and let Jekyll place it under the assets folder.

chalin avatar Sep 17 '19 15:09 chalin

Although I understand the desire to avoid committing generated files, I'm a little leery of introducing yet another way the build can break.

kwalrath avatar Sep 17 '19 22:09 kwalrath

(Just thought that I'd mention in passing that merging in commits where there are local remote and local changes to generated files is no fun. Admittedly, that shouldn't happen too often.)

chalin avatar Nov 20 '19 16:11 chalin

I'm going to close this, as this rarely needs to be updated. Committing it reduces chances for the build to break and reduces build times. If we switch to Dart based tooling in the future, we can reconsider this then.

parlough avatar Jul 02 '23 15:07 parlough