site-www icon indicating copy to clipboard operation
site-www copied to clipboard

CI: check external links via cron build

Open chalin opened this issue 6 years ago • 5 comments

  • [x] Setup cron job.
  • [ ] Adapt scripts so that external link checking is done only in a cron job.

chalin avatar Nov 29 '18 21:11 chalin

It might be possible to fix #1107 at the same time.

chalin avatar Nov 29 '18 21:11 chalin

We should add a test that looks for bad external links, but (unlike flutter.dev’s current behavior) I don’t think we should fail the build just because an external URL no longer works.

Related: #1685, https://github.com/flutter/website/issues/2734

kwalrath avatar Jul 02 '19 15:07 kwalrath

Since this issue has been opened, linkcheck has been updated, and no reports command failures on connection failures. That makes external checking much more robust.

Note that most of the machinery is in place for this, and link checking (which is currently only for internal links), is allowed to fail w/o causing Travis to be alarmed. So, if we don't mind doing external link check for every PR and master build, then all we need to do is use the --external flag of check-links.

Otherwise, a little bit of config could ensure that we only do external link checking for, say, daily cron job builds.

WDYT?

chalin avatar Sep 20 '19 18:09 chalin

For the Flutter website it was suggested that we only check external links every X days, see https://github.com/flutter/website/issues/3079. I assume that we'll want something similar here too?

chalin avatar Oct 18 '19 17:10 chalin

Cron job scheduled to run daily:

image

First cron job run successfully (and none of the jobs trigger a site deploy, per #2011 -- also related is https://github.com/flutter/website/issues/3127):

image

cc @johnpryan @legalcodes

chalin avatar Oct 18 '19 20:10 chalin