site-shared
site-shared copied to clipboard
dart-lang
Clarify process of contributing to site-shared
We've had at least a couple of contributors try to make improvements to files under site-shared by creating a PR for site-www or site-webdev.
We should somehow make clear (maybe in these files? maybe in the CONTRIBUTING.md files of sites that use site-shared?) that changes to files under site-shared need to be made to the site-shared repo.
Related: dart-lang/site-webdev#1813
A similar issue is contributions to other sub-repos. E.g. dart-lang/site-webdev#1809 broke the build because it fixed an angular typo. We should have instead fixed the issue in the angular repo.
We should have instead fixed the issue in the angular repo.
One solution would be to avoid committing the notes sources (since they are autogenerated). Initially I just thought that it was convenient to be able to see the rendered sources.
We should have instead fixed the issue in the angular repo.
One solution would be to avoid committing the notes sources (since they are autogenerated). Initially I just thought that it was convenient to be able to see the rendered sources.
Wouldn't we see them if we did a real build (similar to the API doc situation)? Also, this is independent of the problem of the github and bug links going to the wrong repo, right?
Wouldn't we see them if we did a real build (similar to the API doc situation)?
Yes.
Also, this is independent of the problem of the github and bug links going to the wrong repo, right?
Right.
Good afternoon, I could not figure out how to make changes to the content of the site, if it would not be difficult for you to add to the following text additions
sudo apt-get install clang cmake ninja-build pkg-config libgtk-3-dev liblzma-dev
for Fedora OS
sudo dnf install clang cmake ninja-build pkg-config gtk3-devel xz-devel
