setup-dart icon indicating copy to clipboard operation
setup-dart copied to clipboard

fix: Use `.zip` in archive path

Open dnys1 opened this issue 1 year ago • 2 comments

Fixes https://github.com/dart-lang/setup-dart/issues/118

Ensures that downloads of the Dart SDK zip file carry the .zip extension so that subsequent calls to Expand-Archive on Windows succeed.

Notes

  • The diff of index.mjs is quite large. I believe this is due to the version of Node I'm using (20.7.0). Happy to use a different version to keep the diff small, but wasn't sure which one is currently used. This could be noted in package.json (under engines), if desired, to ensure alignment with external contributions.

  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

dnys1 avatar Dec 31 '23 20:12 dnys1

Thanks @dnys1! Would you mind resolving conflicts? Then we'll take a look.

mit-mit avatar Apr 29 '24 14:04 mit-mit

@mit-mit Done 😄

dnys1 avatar May 01 '24 13:05 dnys1

I'm blocked by this issue. I don't have access to directly contribute to this PR, so I opt to take the commits from this PR, and created a new PR with one more additional commit to fix the build issue: https://github.com/dart-lang/setup-dart/pull/134

ntkme avatar Jun 20 '24 19:06 ntkme

Thanks @ntkme I hadn't seen the build failure. I've pushed a new commit which runs the formatter, rebuilds, and signs the JS using npm run all on Dart 3.4.1.

dnys1 avatar Jun 21 '24 20:06 dnys1

@dnys1 Thanks for the update. @devoncarew Can you please take another look and see if we can get this merged?

ntkme avatar Jun 21 '24 20:06 ntkme

I'll leave for @devoncarew to hit the merge button!

kevmoo avatar Jun 21 '24 22:06 kevmoo

Thanks for the contribution!

devoncarew avatar Jun 24 '24 20:06 devoncarew