fix: Use `.zip` in archive path
Fixes https://github.com/dart-lang/setup-dart/issues/118
Ensures that downloads of the Dart SDK zip file carry the .zip extension so that subsequent calls to Expand-Archive on Windows succeed.
Notes
- The diff of
index.mjsis quite large. I believe this is due to the version of Node I'm using (20.7.0). Happy to use a different version to keep the diff small, but wasn't sure which one is currently used. This could be noted inpackage.json(under engines), if desired, to ensure alignment with external contributions.
- [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
- See our contributor guide for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the Dart style guide and use
dart format. - Most changes should add an entry to the changelog and may need to rev the pubspec package version.
- Changes to packages require corresponding tests.
Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Thanks @dnys1! Would you mind resolving conflicts? Then we'll take a look.
@mit-mit Done 😄
I'm blocked by this issue. I don't have access to directly contribute to this PR, so I opt to take the commits from this PR, and created a new PR with one more additional commit to fix the build issue: https://github.com/dart-lang/setup-dart/pull/134
Thanks @ntkme I hadn't seen the build failure. I've pushed a new commit which runs the formatter, rebuilds, and signs the JS using npm run all on Dart 3.4.1.
@dnys1 Thanks for the update. @devoncarew Can you please take another look and see if we can get this merged?
I'll leave for @devoncarew to hit the merge button!
Thanks for the contribution!