sdk

sdk copied to clipboard

[vm/ffi] Requesting isolate shutdown in a callback

5

We should check that the FFI does not swallow [isolate shutdown](https://api.flutter.dev/flutter/dart-isolate/Isolate/kill.html) requests. It should probably return the error value to C, let C unwind its stack, and continue unwinding the...

dcharkes

From yesterday in e.g. [this log](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738956153912080561/+/u/test_results/ignored_flaky_test_failure_logs): ``` /============================================================\ | ffi/address_of_test/0 broke (Pass -> Crash, expected Pass) | \============================================================/ --- Command "vm_compile_to_kernel" (took 01.000433s): DART_CONFIGURATION=ReleaseXRISCV64 /b/s/w/ir/cache/builder/sdk/pkg/vm/tool/gen_kernel --aot --platform=out/ReleaseXRISCV64/vm_platform_strong.dill -o /b/s/w/ir/cache/builder/sdk/out/ReleaseXRISCV64/generated_compilations/vm-aot-linux-release-riscv64-qemu/tests_ffi_address_of_test/out.dill /b/s/w/ir/cache/builder/sdk/tests/ffi/address_of_test.dart...

mkustermann

[CP] Fix zlib inflation to ignore data past the ADLER32 trailer.

2

### Commit(s) to merge https://dart-review.googlesource.com/c/sdk/+/380861 ### Target stable ### Prepared changelist for beta/stable https://dart-review.googlesource.com/c/sdk/+/381389 ### Issue Description Fixes a regression where `ZLibDecoder` would attempt to read data past the compressed...

brianquinlan

Not able to close/release RawDatagramSocket after receiving a SocketException in Windows Desktop

2

Scanning a local network using UDP packets and the RawDatagramSocket, the socket resources are never released when the socket is seeing a SocketException. Reproduced using a slightly modified example from...

peqi-frontrow

gen_snapshot and dart snapshot sometimes crash on ios flutter buildbot bot

2

from https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/422092/overview [logs](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8739681458534452625/+/u/build_ci_ios_debug_flutter_lib_snapshot:generate_snapshot_bins_flutter_shell_platform_darwin_ios:flutter_framework/stdout) ``` [1641/6217] ACTION //flutter/third_party/dart/runtime/observatory:build_observatory(//build/toolchain/mac:ios_clang_arm) FAILED: gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js vpython3 ../../../flutter/third_party/dart/build/gn_run_binary.py compiled_action ../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart --dfe=../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot compile js -o gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js --packages=../../../flutter/third_party/dart/.dart_tool/package_config.json ../../../flutter/third_party/dart/runtime/observatory/web/main.dart --minify Command failed: /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart --dfe=../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot compile js -o gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js --packages=../../../flutter/third_party/dart/.dart_tool/package_config.json...

aam

Support likely() and unlikely() hints for AOT code optimization

1

```dart // Tell the compiler which branches are going to be taken most of the time. if (unlikely(n == 0)) { // This branch is known to be taken rarely....

tillulen

`_IndexAssembler.assemble`: optimize using `toList(growable: false)`

1

The `assemble` method is a hotspot for `List` generation, and a fixed-length list is faster to generate. --- - [✅] I’ve reviewed the contributor guide and applied the relevant portions...

gmpassos

[web/interop] New JS interop extensions that provide `jsify()` / `dartify()`

8

Currently the `dart:js_interop` provides a `jsify()` method that is described as this: ```dart extension NullableObjectUtilExtension on Object? { /// Converts a Dart object to the JavaScript equivalent if possible. ///...

mkustermann

Analyzer should warn on a mistaken JavaScript-function-body

22

People used to writing JavaScript sometimes end up writing Dart code like: ```dart someFuture.then(... onError: (e, s) => { logError(e, s) }) ``` The issue is using a `=> {...

lrhn

Warn when glob patterns in the analysis options file start with a slash

11

Per the glob package documentation, glob patterns should start with leading slashes, otherwise root files won't be found by a glob pattern. https://pub.dev/packages/glob#:~:text=If%20**%20appears,by%20it%20either. Starting with a leading slash does not...

dmrickey