sdk icon indicating copy to clipboard operation
sdk copied to clipboard

New assist to add/edit `hide` at import for ambiguous import

Open FMorschel opened this issue 1 year ago • 11 comments

This PR adds a new assist to add/update hide to imports when ambiguous_import is triggered.

Related to https://github.com/dart-lang/sdk/issues/56830.


  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

FMorschel avatar Sep 20 '24 16:09 FMorschel

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/386020

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

copybara-service[bot] avatar Sep 20 '24 16:09 copybara-service[bot]

Requested @bwilkerson to review on Gerrit, as he wrote the options list to fix ambiguous_import.

FMorschel avatar Sep 20 '24 16:09 FMorschel

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 03 '24 12:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 03 '24 12:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 10 '24 16:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 10 '24 16:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 10 '24 18:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 10 '24 18:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 10 '24 18:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 16 '24 13:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 16 '24 13:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 22 '24 13:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 22 '24 13:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 29 '24 23:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 29 '24 23:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 30 '24 00:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 30 '24 00:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 30 '24 00:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Oct 30 '24 00:10 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 01 '24 01:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 01 '24 01:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 01 '24 21:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 01 '24 21:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 06 '24 18:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 07 '24 16:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 07 '24 16:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 14 '24 11:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 14 '24 11:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 14 '24 12:11 copybara-service[bot]

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

copybara-service[bot] avatar Nov 14 '24 12:11 copybara-service[bot]