Failures on [dart2wasm] Use unsafeCast in a few places...Reland "[vm] Move `ResolveUri` to bin"

[aam]

There are new test failures on [dart2wasm] Use unsafeCast in a few places...Reland "[vm] Move ResolveUri to bin".

The tests

co19/LibTest/core/DateTime/millisecond_A01_t01 Crash (expected Pass)
co19/LibTest/core/List/List.generate_A01_t02 Crash (expected Pass)
co19/LibTest/core/Set/add_A01_t04 Crash (expected Pass)
co19/LibTest/math/Point/distanceTo_A01_t01 Crash (expected Pass)
language/regress/regress21795_test Crash (expected Pass)

are failing on configurations

dart2wasm-linux-optimized-jsc

/=====================================================================================\
| co19/LibTest/core/DateTime/millisecond_A01_t01 broke (Pass -> Crash, expected Pass) |
\=====================================================================================/

--- Command "dart2wasm" (took 02.000269s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart compile wasm -O1 -Dtest_runner.configuration=dart2wasm-linux-optimized-jsc /b/s/w/ir/tests/co19/src/LibTest/core/DateTime/millisecond_A01_t01.dart -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_DateTime_millisecond_A01_t01/millisecond_A01_t01.wasm

exit code:
0

stdout:
Generated wasm module '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_DateTime_millisecond_A01_t01/millisecond_A01_t01.wasm', and JS init file '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_DateTime_millisecond_A01_t01/millisecond_A01_t01.mjs'.

--- Command "jsc" (took 310ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_DateTime_millisecond_A01_t01 pkg/dart2wasm/tool/run_benchmark --jsc /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_DateTime_millisecond_A01_t01/millisecond_A01_t01.wasm

exit code:
-11

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-optimized-jsc co19/LibTest/core/DateTime/millisecond_A01_t01


/===================================================================================\
| co19/LibTest/core/List/List.generate_A01_t02 broke (Pass -> Crash, expected Pass) |
\===================================================================================/

--- Command "dart2wasm" (took 02.000171s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart compile wasm -O1 -Dtest_runner.configuration=dart2wasm-linux-optimized-jsc /b/s/w/ir/tests/co19/src/LibTest/core/List/List.generate_A01_t02.dart -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_List_List.generate_A01_t02/List.generate_A01_t02.wasm

exit code:
0

stdout:
Generated wasm module '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_List_List.generate_A01_t02/List.generate_A01_t02.wasm', and JS init file '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_List_List.generate_A01_t02/List.generate_A01_t02.mjs'.

--- Command "jsc" (took 219ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_List_List.generate_A01_t02 pkg/dart2wasm/tool/run_benchmark --jsc /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_List_List.generate_A01_t02/List.generate_A01_t02.wasm

exit code:
-11

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-optimized-jsc co19/LibTest/core/List/List.generate_A01_t02


/========================================================================\
| co19/LibTest/core/Set/add_A01_t04 broke (Pass -> Crash, expected Pass) |
\========================================================================/

--- Command "dart2wasm" (took 02.000921s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart compile wasm -O1 -Dtest_runner.configuration=dart2wasm-linux-optimized-jsc /b/s/w/ir/cache/builder/sdk/tests/co19/src/LibTest/core/Set/add_A01_t04.dart -o /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_Set_add_A01_t04/add_A01_t04.wasm

exit code:
0

stdout:
Generated wasm module '/b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_Set_add_A01_t04/add_A01_t04.wasm', and JS init file '/b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_Set_add_A01_t04/add_A01_t04.mjs'.

--- Command "jsc" (took 277ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_Set_add_A01_t04 pkg/dart2wasm/tool/run_benchmark --jsc /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_core_Set_add_A01_t04/add_A01_t04.wasm

exit code:
-11

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-optimized-jsc co19/LibTest/core/Set/add_A01_t04


/=================================================================================\
| co19/LibTest/math/Point/distanceTo_A01_t01 broke (Pass -> Crash, expected Pass) |
\=================================================================================/

--- Command "dart2wasm" (took 02.000213s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart compile wasm -O1 -Dtest_runner.configuration=dart2wasm-linux-optimized-jsc /b/s/w/ir/tests/co19/src/LibTest/math/Point/distanceTo_A01_t01.dart -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_math_Point_distanceTo_A01_t01/distanceTo_A01_t01.wasm

exit code:
0

stdout:
Generated wasm module '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_math_Point_distanceTo_A01_t01/distanceTo_A01_t01.wasm', and JS init file '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_math_Point_distanceTo_A01_t01/distanceTo_A01_t01.mjs'.

--- Command "jsc" (took 259ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_math_Point_distanceTo_A01_t01 pkg/dart2wasm/tool/run_benchmark --jsc /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_co19_src_LibTest_math_Point_distanceTo_A01_t01/distanceTo_A01_t01.wasm

exit code:
-11

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-optimized-jsc co19/LibTest/math/Point/distanceTo_A01_t01


/========================================================================================\
| language/regress/regress21795_test failed again (RuntimeError -> Crash, expected Pass) |
\========================================================================================/

--- Command "dart2wasm" (took 01.000988s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart compile wasm -O1 -Dtest_runner.configuration=dart2wasm-linux-optimized-jsc /b/s/w/ir/tests/language/regress/regress21795_test.dart -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_language_regress_regress21795_test/regress21795_test.wasm

exit code:
0

stdout:
Generated wasm module '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_language_regress_regress21795_test/regress21795_test.wasm', and JS init file '/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_language_regress_regress21795_test/regress21795_test.mjs'.

--- Command "jsc" (took 313ms):
DART_CONFIGURATION=ReleaseX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_language_regress_regress21795_test pkg/dart2wasm/tool/run_benchmark --jsc /b/s/w/ir/out/ReleaseX64/generated_compilations/dart2wasm-linux-optimized-jsc/tests_language_regress_regress21795_test/regress21795_test.wasm

exit code:
-11

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-optimized-jsc language/regress/regress21795_test

[osa1]

Could https://dart-review.googlesource.com/c/sdk/+/373240 be the change that introduced these failures? I don't think any of the changes in the range can introduce this kind of failure.

[liamappelbe]

I'm also seeing this crash in:

• co19/LibTest/collection/DoubleLinkedQueue/addLast_A01_t01, co19/LibTest/math/Point/operator_mult_A01_t01, co19/TypeSystem/subtyping/dynamic/generated/named_function_types_fail_arguments_binding_fail_A21_t02
• lib/typed_data/float32x4_shuffle_test
• co19/LibTest/core/double/operator_LT_A01_t01
• co19/LibTest/core/double/operator_GT_A01_t01

The results feed is interesting. These failures are spread over 5 different feed entries, each with a different set of culprits. Some of the culprit ranges overlap, but most don't. That makes me think it's not related to a specific change in the main repo, but some other piece of infra.

[mkustermann]

The jsc bot isn't entirely stable because WebKit/JavaScriptCore's WasmGC implementation still has some bugs.

Will close in favor of the general https://github.com/dart-lang/sdk/issues/54757

@liamappelbe @aam The dart2wasm team maintains the wasm builders, so you don't have to triage unapproved wasm failures as part of VM gardening.