sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Macro test failures

Open a-siva opened this issue 1 year ago • 3 comments

There are new test failures on [cfe] Make kernel AST and CompilerOptions use strong mode by default...DAS: Refactor the logic determining the location of a new ignore-comment.

The tests

language/macros/augment/class_declarations_macro_test DartkCrash (expected Pass)
language/macros/augment/class_types_macro_test DartkCrash (expected Pass)
language/macros/introspect/class_test DartkCrash (expected Pass)
language/macros/introspect/declaration_introspect_cycle_failure_test DartkCrash (expected Pass)
language/macros/json/json_serializable_test DartkCrash (expected Pass)
language/macros/nesting/macro_impl_uses_macro1_test DartkCrash (expected Pass)
language/macros/nesting/macro_impl_uses_macro2_test DartkCrash (expected Pass)

are failing on configurations

vm-aot-android-release-arm64c
vm-aot-android-release-arm_x64
vm-aot-linux-debug-simarm_x64
vm-aot-linux-release-simarm_x64
vm-aot-linux-release-x64
vm-aot-mac-release-arm64
vm-aot-mac-release-x64
vm-aot-win-release-x64
vm-linux-debug-simriscv64
vm-linux-release-simarm

a-siva avatar Apr 05 '24 21:04 a-siva

This might be a duplicate of https://github.com/dart-lang/sdk/issues/55374

a-siva avatar Apr 05 '24 21:04 a-siva

Similar issue on the DDC hostasserts bot:

(ddc-hostasserts-linux-d8):
    language/macros/augment/class_declarations_macro_test   (flaky -> Crash, expected Pass)
    language/macros/introspect/declaration_introspect_cycle_failure_test   (flaky -> Crash, expected Pass)
    language/macros/json/json_serializable_test   (flaky -> Crash, expected Pass)
    language/macros/augment/class_types_macro_test   (flaky -> Crash, expected Pass)
    language/macros/introspect/class_test   (flaky -> Crash, expected Pass)
    language/macros/nesting/macro_impl_uses_macro2_test   (flaky -> Crash, expected Pass)
    language/macros/nesting/macro_impl_uses_macro1_test   (flaky -> Crash, expected Pass)

srujzs avatar Apr 15 '24 16:04 srujzs

On https://github.com/dart-lang/sdk/commit/defd81e31d25ea4a9683ea08da3d64dc2148cac9 tests outcomes changed:

DartkCrash -> CompileTimeError (expected Pass) language/macros/introspect/declaration_introspect_cycle_failure_test DartkCrash -> RuntimeError (expected Pass) language/macros/json/json_serializable_test

aam avatar Jun 25 '24 16:06 aam

language/macros tests were removed in 497a88bb261567bfe2f0962224f5a3a7286c1b11.

alexmarkov avatar Feb 05 '25 16:02 alexmarkov