pkg/dev_compiler/test/expression_compiler/asset_file_system_test is flaky/failing

[srujzs]

First noticed here as it turned the pkg-linux-debug bot red: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8807002776779726001/+/u/test_results/stdout.

[nshahan]

@annagrin Any idea what might be going on?

Here is a log from a failing run:

--- Command "vm" (took 59.000160s):
DART_CONFIGURATION=DebugX64 CHROME_PATH=/b/s/w/ir/cache/builder/sdk/third_party/browsers/chrome/chrome/google-chrome out/DebugX64/dart-sdk/bin/dart --enable_asserts -Dtest_runner.configuration=unittest-asserts-debug-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/test/expression_compiler/asset_file_system_test.dart

exit code:
255

stdout:
00:00 +0: AssetFileSystem with a server (setUpAll)

00:00 +0: AssetFileSystem with a server can tell if file exists

00:01 +1: AssetFileSystem with a server can tell if file does not exist

00:01 +2: AssetFileSystem with a server can read existing file using readAsBytes

00:01 +3: AssetFileSystem with a server can read and decode existing file using readAsBytes

00:01 +4: AssetFileSystem with a server can read existing file using readAsString

00:01 +5: AssetFileSystem with a server cannot read non-existing file

00:01 +6: AssetFileSystem with a server can read a lot of files concurrently

00:04 +7: AssetFileSystem with a server (tearDownAll)

00:04 +7: AssetFileSystem with a noisy server (setUpAll)

00:04 +7: AssetFileSystem with a noisy server can tell if file exists

00:05 +8: AssetFileSystem with a noisy server can tell if file does not exist

00:05 +9: AssetFileSystem with a noisy server can read existing file using readAsBytes

00:05 +10: AssetFileSystem with a noisy server can read and decode existing file using readAsBytes

00:05 +11: AssetFileSystem with a noisy server can read existing file using readAsString

00:05 +12: AssetFileSystem with a noisy server cannot read non-existing file

00:05 +13: AssetFileSystem with a noisy server readAsString is faster than decoding result of readAsBytes

00:05 +14: AssetFileSystem with a noisy server can read a lot of files concurrently

00:14 +14 -1: AssetFileSystem with a noisy server can read a lot of files concurrently [E]

  type 'TimeoutException' is not a subtype of type '() => FutureOr<HttpClientRequest>' in type cast

  package:dev_compiler/src/kernel/retry_timeout_client.dart 75:19  RetryTimeoutClient._retry.<fn>
  dart:async/zone.dart 1383:47                                     _rootRun
  dart:async/zone.dart 1293:19                                     _CustomZone.run
  dart:async/future_impl.dart 865:34                               Future.timeout.<fn>
  dart:async/zone.dart 1383:47                                     _rootRun
  dart:async/zone.dart 1293:19                                     _CustomZone.run
  dart:async/zone.dart 1201:7                                      _CustomZone.runGuarded
  dart:async/zone.dart 1241:23                                     _CustomZone.bindCallbackGuarded.<fn>
  dart:async/zone.dart 1391:13                                     _rootRun
  dart:async/zone.dart 1293:19                                     _CustomZone.run
  dart:async/zone.dart 1225:23                                     _CustomZone.bindCallback.<fn>
  dart:async-patch/timer_patch.dart 18:15                          Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 398:19                        _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 429:5                         _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 192:12                     _RawReceivePortImpl._handleMessage
  

00:14 +14 -1: AssetFileSystem with a noisy server (tearDownAll)

00:14 +14 -1: AssetFileSystem with an unreliable server (setUpAll)

00:14 +14 -1: AssetFileSystem with an unreliable server can tell if file exists

00:15 +15 -1: AssetFileSystem with an unreliable server can tell if file does not exist

00:15 +16 -1: AssetFileSystem with an unreliable server can read existing file using readAsBytes

00:15 +17 -1: AssetFileSystem with an unreliable server can read and decode existing file using readAsBytes

00:15 +18 -1: AssetFileSystem with an unreliable server can read existing file using readAsString

00:16 +19 -1: AssetFileSystem with an unreliable server cannot read non-existing file

00:16 +20 -1: AssetFileSystem with an unreliable server can read a lot of files concurrently

00:21 +21 -1: AssetFileSystem with an unreliable server (tearDownAll)

00:21 +21 -1: AssetFileSystem with failing server (setUpAll)

00:21 +21 -1: AssetFileSystem with failing server cannot tell if file exists

00:25 +22 -1: AssetFileSystem with failing server cannot tell if file does not exist

00:29 +23 -1: AssetFileSystem with failing server cannot read existing file using readAsBytes

00:33 +24 -1: AssetFileSystem with failing server cannot read existing file using readAsString

00:37 +25 -1: AssetFileSystem with failing server cannot read non-existing file

00:42 +26 -1: AssetFileSystem with failing server (tearDownAll)

00:42 +26 -1: Some tests failed.

[annagrin]

Looks like there was a change that added a cast on line 75 that is probably meant to be around the closure, not the TimeOutException: https://github.com/dart-lang/sdk/commit/8ac87895fe3326f3cf94a675b0a859147b300746#r80876116