dart-lang
The markdown `todo` is not rendered correctly
The markdown todo isn't rendered correctly.
- [ ] <=== Hope this renders correctly.
Currently in pub.dev
Expected as Github readme
This seems to be a bug on pub-dev, as running markdown on the input renders the correct HTML:
dart pub run markdown --extension-set GitHubWeb
Deprecated. Use `dart run` instead.
## TODO
- [x] Support optional `horizontal` mode
- [x] Separator support in `ListView`
<h2 id="todo">TODO</h2>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" checked="true"></input>Support optional <code>horizontal</code> mode</li>
<li class="task-list-item"><input type="checkbox" checked="true"></input>Separator support in <code>ListView</code></li>
</ul>
This seems to be a bug on pub-dev, as running markdown on the input renders the correct HTML:
dart pub run markdown --extension-set GitHubWeb Deprecated. Use `dart run` instead. ## TODO - [x] Support optional `horizontal` mode - [x] Separator support in `ListView` <h2 id="todo">TODO</h2> <ul class="contains-task-list"> <li class="task-list-item"><input type="checkbox" checked="true"></input>Support optional <code>horizontal</code> mode</li> <li class="task-list-item"><input type="checkbox" checked="true"></input>Separator support in <code>ListView</code></li> </ul>
So is there anything I can do to fix this? I am not getting your solution.
So is there anything I can do to fix this? I am not getting your solution.
No action is needed on your part. I've tagged the issue as bug, and hopefully we'll have some time to look into it why it happens and fix it.
@jonasfj: This seems to be caused by the HTML sanitization of the markdown code. We could either allow input in package:sanitize_html, or rewrite the <input> element (and maybe related styles) to <span> elements and/or unicode characters. wdyt?
They are rendered as input on github because you actually can modify them.
Although they are rendered as disabled input when not signed in...
Hmm, I guess: https://github.com/gjtorikian/html-pipeline/blob/main/lib/html/pipeline/sanitization_filter.rb
which is the basis for sanitize_html is outdated.
We might need to take a look at refactoring sanitize_html to allow more, and be more flexible.
We might need to take a look at refactoring sanitize_html to allow more, and be more flexible.
I don't mind keeping it strict, however, if we don't change sanitize_html, then we should convert the inputs to unicode characters instead. Which way do you prefer?
won't unicode break in some browsers / cases....?
IIRC it depends on the font face and the system fonts available. An alternative would be to use just an SVG icon as a replacement, e.g.
In that case I propose that we use <input type="checkbox" disabled> maybe we patch package:markdown to create disabled checkboxes?
SVG would also be nice, but how can we reduce the number of hacks?
Can we pass parameters to package:markdown that changes how it renders OrderedListWithCheckboxSyntax ?
I guess we could subclass OrderedListWithCheckboxSyntax? and change the output it returns..
Can we pass parameters to package:markdown that changes how it renders OrderedListWithCheckboxSyntax ?
Unfortunately, it looks like, changing the package:markdown rendering is not easy:
https://github.com/dart-lang/markdown/blob/master/lib/src/block_syntaxes/list_syntax.dart#L57-L237
In that case I propose that we use maybe we patch package:markdown to create disabled checkboxes?
We'd need to both change the markdown output to use disabled and also change package:sanitize_html to not remove the input tag and its attributes. I'd rather prefer this one than just changing it into an icon (that we need to distribute).
