withResource awaits sync callback

[kinex]

withResource is defined as: Future<T> withResource<T>(FutureOr<T> Function() callback)

Method body has this line: return await callback();

From my understanding the correct way to write that is something like:

final result = callback();
if (result is Future<T>) {
  return await result;
} else {
  return result;
}

I found this while searching how to use FutureOr<T> correctly. Current code in Pool is not a good sample to follow, or am I missing something?

[nioncode]

await can be used on Future<T> as well as on T directly, i.e. it is perfectly fine to await a synchronous value (it will be wrapped into a Future under the hood).

That said, using await will always introduce an asynchronous gap and yield execution back to the event loop, which will introduce a delay in processing if used unnecessarily in a tight-loop, but I don't think this optimization is needed in this case.

See also: https://stackoverflow.com/questions/59213196/what-is-the-purpose-of-futureor