path icon indicating copy to clipboard operation
path copied to clipboard

Rename toUri and fromUri to toUrl and fromUrl

Open DartBot opened this issue 9 years ago • 8 comments

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3 Originally opened as dart-lang/sdk#19145


These functions (like the rest of path's URL support) only make sense with URLs, not URIs, and calling that out in the name matches [UrlStyle] and the [url] getter.

DartBot avatar Jun 03 '15 23:06 DartBot

@nex3 Is the issue still relevant and needs help with?

jddeep avatar Feb 22 '20 05:02 jddeep

This is a question for the current maintainer of the package.

nex3 avatar Feb 24 '20 18:02 nex3

Well can we tag the maintainer for confirmation?

jddeep avatar Feb 25 '20 04:02 jddeep

We should do this if we have a breaking change release, we're still working out whether the null safety migration is going to involve breaking version bumps. I wouldn't put any effort towards this yet.

If we decide on breaking version bumps we will want to add the new one and deprecate the old for a release to allow for a smooth transition.

natebosch avatar Mar 12 '20 23:03 natebosch

Fixed this issue at https://github.com/jinosh05/path and gave pull request

jinosh05 avatar May 29 '23 11:05 jinosh05

@nex3 Shall we close this issue as I have already renamed those variables in the recent commit

jinosh05 avatar Jun 01 '23 11:06 jinosh05

I'm no longer a maintainer of this package.

nex3 avatar Jun 01 '23 22:06 nex3

It's unlikely we'll have enough bandwidth for this package that a breaking change like this is worthwhile.

natebosch avatar Jun 01 '23 23:06 natebosch