native icon indicating copy to clipboard operation
native copied to clipboard

[ffi] Set default parameter name in using callback

Open dickermoshe opened this issue 8 months ago • 2 comments

This is an extremely minor change. Providing a argument name makes auto complete better.

Before:

https://github.com/user-attachments/assets/b7b7a80f-23e6-469c-ac1b-e4b0ad8de781

After:

https://github.com/user-attachments/assets/6daa21c4-8248-487c-ac60-c565964ba868


  • [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

dickermoshe avatar Apr 28 '25 17:04 dickermoshe

PR Health

Breaking changes :heavy_check_mark:
Package Change Current Version New Version Needed Version Looking good?
ffi None 2.1.4 2.1.4 2.1.4 :heavy_check_mark:
Changelog Entry :exclamation:
Package Changed Files
package:ffi pkgs/ffi/lib/src/arena.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks :warning:

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
ffi MallocAllocator
CallocAllocator

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers :heavy_check_mark:
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

github-actions[bot] avatar Apr 29 '25 06:04 github-actions[bot]

If you want a release of the package, please also bump the version and add an entry to the changelog.

dcharkes avatar Apr 29 '25 06:04 dcharkes