dart-lang
[ffigen] Context field for ObjC blocks/protocols
ObjC implementation of jnigen's context proposal for interface implementation. The idea is that this context map would be stored on the native side as a map of weak references, to break Dart <-> Java/ObjC reference cycles that cause memory leaks.
Java doesn't have lambdas, so they only have to worry about interface implementation. But in the ObjC case we'll need to apply this to both blocks and protocols.
Does every block/protocol method need to have a context object, even if they're not going to use it? This would add a small memory and performance overhead, as well as being a bit annoying for users.
I think it would make more sense to have separate constructors for capturing and non-capturing blocks/protocols:
// Making a block without context.
final block = VoidBlock.listener(() {
// Do stuff...
});
// Making a block with context.
final block = VoidBlock.listenerWithContext((context) {
// Do stuff...
}, context: {'foo': foo});
This also has the advantage that existing blocks/protocols don't need to be changed, making it a non-breaking change that we can punt until after ffigen 20.