linter icon indicating copy to clipboard operation
linter copied to clipboard

Add a lint to ensure library dependency graph is a DAG

Open a14n opened this issue 8 years ago • 4 comments

See https://github.com/flutter/flutter/pull/11135#discussion_r126749076

a14n avatar Jul 19 '17 07:07 a14n

I like this type of rule but I think it needs a more comprehensive specification, there are objects that know about each other and that is OK, for instance similar static analysis programs in java and c# allow it at the package or namespace level, How should we do it here? The equivalent might be directory, but so far I haven't seen that convention followed in the dart community.

alexeieleusis avatar Jul 19 '17 16:07 alexeieleusis

I meant library dependency graph.

a14n avatar Jul 19 '17 19:07 a14n

Even in that case. I notice a strong tendency for one file per library and one class per file.

While this is the kind of thing I would like to have contributed from day one, it might beyond the scope of a linter, and at the very least will face challenges to be as performant as needed for a linter.

alexeieleusis avatar Jul 19 '17 20:07 alexeieleusis

Wasn't there some discussion about tagging linter rules in slow and fast and then for example run fast rules live and others only on commit or similar?

zoechi avatar Jul 20 '17 11:07 zoechi