added support for flutter 'lib\' dir

[harrowmykel]

• This pull request adds support for flutter 'lib/' directory

---

• [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

[mosuem]

I would like to keep the intl_translation package independent of Flutter implementation details, what are you trying to achieve exactly which can't be fixed with the current setup?

[harrowmykel]

With this PR you can give the program any directory and it will parse all the dart files in the directory and sub directories for you.

On Mon, 21 Aug 2023, 15:35 Moritz @.***> wrote:

I would like to keep the intl_translation package independent of Flutter implementation details, what are you trying to achieve exactly which can't be fixed with the current setup?

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/i18n/pull/700#issuecomment-1686343654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLTOBK2CMHD5FHJJD2MFLTXWNPZHANCNFSM6AAAAAA3QNOUAQ . You are receiving this because you authored the thread.Message ID: @.***>

[mosuem]

This is already now possible using glob syntax, see the readme. Or am I missing something?

[harrowmykel]

The glob sythax does not do the subfolders

On Tue, 22 Aug 2023, 16:13 Moritz @.***> wrote:

This is already now possible using glob syntax, see the readme. Or am I missing something?

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/i18n/pull/700#issuecomment-1688270282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLTOBJ2XM25VVU2BMMSGNLXWS5BFANCNFSM6AAAAAA3QNOUAQ . You are receiving this because you authored the thread.Message ID: @.***>

[mosuem]

The glob syntax is a bash feature, so for example using dart run bin/extract_to_arb.dart $(find example/ -name '*.dart') in the intl_translation root does do the trick. I agree however that an option to specify the folders directly seems a lot more convenient.

[github-actions[bot]]

PR Health

Package publish validation :heavy_check_mark:

Details

Package	Version	Status
package:intl	0.19.0-dev	pre-release version (no publish necessary)
package:intl4x	0.5.0	already published at pub.dev
package:intl_translation	0.19.1-dev	pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers :heavy_check_mark:

Details

// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/intl/lib/src/global_state.dart
pkgs/intl/lib/locale.dart
pkgs/intl/lib/find_locale.dart
pkgs/intl/test/number_format_compact_icu_test.dart
pkgs/intl/test/number_format_compact_web_test.dart
pkgs/intl_translation/test/two_components/app_messages_all.dart
pkgs/intl_translation/test/two_components/app_messages_all_locales.dart
pkgs/intl_translation/test/two_components/component_messages_fr_xyz123.dart
pkgs/intl_translation/test/two_components/app_messages_fr.dart
pkgs/intl_translation/test/two_components/component_messages_all_locales.dart
pkgs/intl_translation/test/two_components/component_messages_all.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all_locales.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_fr.dart
pkgs/intl_translation/example/lib/generated/messages_iw.dart
pkgs/intl_translation/example/lib/generated/messages_de.dart
pkgs/intl_translation/example/lib/generated/messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_en.dart
pkgs/intl_translation/example/lib/generated/messages_all.dart
pkgs/intl_translation/example/lib/generated/messages_de_CH.dart
pkgs/intl_translation/example/lib/generated/messages_es.dart

Changelog Entry :heavy_check_mark:

Details

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage :warning:

Details

File	Coverage
pkgs/intl_translation/bin/extract_to_arb.dart	:broken_heart: Not covered
pkgs/intl_translation/lib/src/directory_utils.dart	:broken_heart: Not covered
pkgs/intl_translation/lib/src/ffile_system_entity.dart	:broken_heart: Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

[mosuem]

Closing as there is no activity.