i18n icon indicating copy to clipboard operation
i18n copied to clipboard

Use the new build system

Open kevmoo opened this issue 7 years ago • 8 comments

Would likely be very helpful with frequent builds...

kevmoo avatar Jun 02 '18 00:06 kevmoo

Yes! The first step towards this, would be to remove most of the logic from bin/generate_from_arb.dart and put it inside lib/. Then at least we would be able to write our own builders for it. Right now, there is a lot of logic inside the bin/generate_from_arb.dart file that I need to copy into my builder to make it work.

enyo avatar Mar 08 '19 09:03 enyo

Clarification: new build system is package:build.

dotdoom avatar Mar 31 '19 08:03 dotdoom

...and friend :-)

On Sun, Mar 31, 2019, 01:09 Artem Sheremet [email protected] wrote:

Clarification: new build system is package:build https://pub.dartlang.org/packages/build.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/i18n/issues/499, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCiioI6TyZ5TrO2cztZFRgLcXjZaSlks5vcG1QgaJpZM4UXd-j .

kevmoo avatar Mar 31 '19 16:03 kevmoo

Hmm. I wonder if it would actually be preferable to remove it to a separate package entirely. The general logic is already in generate_localized.dart, and the idea is that readers/writers for a particular format only need format-specific information. Having that in a separate package would make it easier for people to use, though at the cost of it being harder to use a default.

alan-knight avatar Apr 01 '19 21:04 alan-knight

We should look at having a mono-repo if we create yet another intl package.

Keeping these in one repo would be nice...

kevmoo avatar Apr 01 '19 21:04 kevmoo

Pardon my ignorance, but if analyzer is part of dart-sdk anyway, what's the point of this package, intl_translation? It seems trivial to have intl depend on analyzer.

dotdoom avatar Apr 07 '19 13:04 dotdoom

Analyzer ships with the dart sdk but is not part of it. That is, a Dart application that depends on the SDK does not depend on on the analyzer. If an application uses Intl at run-time, having it depend on analyzer would increase the code size significantly.

alan-knight avatar Apr 08 '19 18:04 alan-knight

I was kind of expecting that Dart's tree shaking would remove analyzer if it's not being used (even though it's listed in dependencies).

But even then, wouldn't it be possible to have analyzer in dev_dependencies?

dotdoom avatar Apr 09 '19 08:04 dotdoom