http2
http2 copied to clipboard
Increase Window Update size
Instead of sending small window updates, the same size as the DATA
length received, send larger updates once a certain portion of the window has been used up, as suggested here.
- [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
- See our contributor guide for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the Dart style guide and use
dart format
. - Most changes should add an entry to the changelog and may need to rev the pubspec package version.
- Changes to packages require corresponding tests.
Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
PR Health
Breaking changes :heavy_check_mark:
Details
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
http2 | None | 2.3.1-wip | 2.3.1-wip | 2.3.1-wip | :heavy_check_mark: |
Changelog Entry :exclamation:
Details
Package | Changed Files |
---|---|
package:http2 | lib/http2.dart lib/src/flowcontrol/window.dart lib/src/flowcontrol/window_handler.dart lib/src/frames/frames.dart lib/src/hpack/hpack.dart pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check
.
Coverage :warning:
Details
File | Coverage |
---|---|
lib/http2.dart | :broken_heart: Not covered |
lib/src/flowcontrol/window.dart | :green_heart: 100 % |
lib/src/flowcontrol/window_handler.dart | :green_heart: 100 % |
lib/src/frames/frames.dart | :broken_heart: Not covered |
lib/src/hpack/hpack.dart | :green_heart: 96 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks :heavy_check_mark:
Details
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers :heavy_check_mark:
Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
test/src/flowcontrol/mocks.mocks.dart |
Package publish validation :heavy_check_mark:
Details
Package | Version | Status |
---|---|---|
package:http2 | 2.3.1-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.