http icon indicating copy to clipboard operation
http copied to clipboard

Published 20 hours ago • verified publisher icon dart-lang

Add Response.url

Open natebosch opened this issue 2 years ago • 2 comments

Closes #321, closes #623, closes #692 Fixes #293

Add a Uri field to BaseResponse with the final, potentially redirected, url for the content.

The field is nullable for backwards compatibility - TODO: consider if this should be non-nullable from the start, or if it can be published nullable first and become non-nullable (and the constructor arg required) in the next breaking release.

This may break tests which use bocks but do not mock the field used to read the URL.

natebosch avatar May 25 '22 20:05 natebosch

This is going to need more validation and potentially a rollout plan.

natebosch avatar May 25 '22 20:05 natebosch

Thankyou !!

glassmonkey avatar May 29 '22 15:05 glassmonkey

Hello, could you please update on the status of this PR? We faced the issue in our project that getting the final redirected URL is not possible from http.Response. It would be great to have this functionality. Thanks!

glhvta avatar Mar 02 '23 11:03 glhvta

This is blocked on a breaking version change.

natebosch avatar Mar 06 '23 20:03 natebosch

Any update on this?

henryssunday avatar Oct 04 '23 06:10 henryssunday