http
http copied to clipboard
dart-lang
(BrowserClient) add constructor to set withCredentials value
Hi,
I just added a constructor that takes an optional withCredentials value.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
I don't see how this is going to help, because the only reference to the constructor call is this global function:
BaseClient createClient() => BrowserClient(); (lib/src/browser_client.dart - line 20)
So withCredentials will always have it's default value.
Closing this, as it is stale and the files are out of date. Feel free to reopen in case you still want to land it!
