#4134. Add/update tests regarding whitespaces and interrupting lines
Some comments to this PR.
- The updated test
test_removesSpaceAfterTripleSlashesis failing. But the specification clearly states that
For each line that begins with
///, the parser removes the three slashes and all leading whitespace to produce the documentation text
So, I believe it is a bug in the current implementation. It should be fixed to follow the spec.
-
test_whitespacesInCodeSpanalso fails. The spec says that whitespaces inside fenced code blocks should be preserved. But in this test we have a code span (`). Spec says that fenced code blocks are the only exception in all other cases all leading whitespaces should be removed. Therefore it is an implementation issue again. - The spec says "Exception: inside fenced code blocks (
```)...". Github flavored markdown also supports~~~as begin/end of code blocks. Probably it makes sense to mention it to the spec. Say "Exception: inside fenced code blocks (``` or ~~~)...".
cc @srawlins because the change affects his comment.
@szakarias @athomas please grant me the permission to assign reviewers.
@szakarias @athomas please grant me the permission to assign reviewers.
Done
@szakarias @athomas please grant me the permission to assign reviewers.
Done
Thanks!
@szakarias @eernstg please review. Some checks failed with SubprocessException[command: "dart analyze --fatal-infos .", workingDirectory: "(null)", exitCode: 2, environment: {}] but it looks like an infra issue.
I'll just remain aware of this work, perhaps adding a comment now and then, but not do regular full reviews.