dartdoc icon indicating copy to clipboard operation
dartdoc copied to clipboard

dartdoc styling seems off on bleeding edge and dev

Open mraleph opened this issue 3 years ago • 5 comments

Compare

dev

Screen Shot 2022-09-28 at 13 03 29

beta

Screen Shot 2022-09-28 at 13 04 05

stable

Screen Shot 2022-09-28 at 13 04 38

Stable looks fine visually. Good padding between dropdown and contents, easy to read (method name first, classname under it). Then progressively UI deteriorates. Beta introduces weird boxes around method names, class name is too prominent, padding from top and left is inconsistent. Dev gets even worse. No padding on the left, too much padding on top, class name is written two times (on top and on the right).

I suggest to go back to nice and compact output from the stable unless there is some strong reason why we don't want that. Otherwise maybe we need some CSS tweaks to make things more consistent.

/cc @mit-mit

mraleph avatar Sep 28 '22 11:09 mraleph

Thanks for the feedback. Most of this is intentional 🤷 . In a recent intern project, the changes which resulted in the diff from stable to beta went through a UX review. After that, @Hixie gave feedback that the new design was very busy and there were too many lines for each result, so I streamlined them into one line each, which results in what you see in dev.

Everything you cite about dev is accidental:

  • zero padding on the left of each result
  • too much padding on the top
  • class name is written twice

srawlins avatar Sep 28 '22 15:09 srawlins

@srawlins do you have any artifacts from UX review? I'd be curious to read the motivation. Stable seems much cleaner to me than either dev or beta, so there must be something I don't grasp.

mraleph avatar Sep 28 '22 16:09 mraleph

The screenshot for dev has two lines per result still, is that intentional? I agree that the stable screenshot is cleaner, but I think it'd be even cleaner if there was literally just one line per result (and no headers in the results) and also if the library was explicitly mentioned in the line (so you can distinguish dart:html and package:flutter results, for example).

Hixie avatar Sep 28 '22 17:09 Hixie

The screenshot for dev has two lines per result still, is that intentional?

No, accidental.

srawlins avatar Sep 28 '22 19:09 srawlins

I agree that the stable screenshot is cleaner, but I think it'd be even cleaner if there was literally just one line per result (and no headers in the results)

Yeah. Rust does this (though their design does not fit for us - because our search box is located in the corner) and theirs in the center.

Screen Shot 2022-09-29 at 09 42 14

Probably we could still render things as dart:html > Event > stopPropagation following the same format as breadcrumbs at the top of the page use. Though this will require extending the width of the dropdown.

mraleph avatar Sep 29 '22 07:09 mraleph