dartdoc icon indicating copy to clipboard operation
dartdoc copied to clipboard

members from hidden subclass are shown as inherited

Open kevmoo opened this issue 4 years ago • 3 comments

See https://pub.dev/documentation/shelf/latest/index.html

There classes https://pub.dev/documentation/shelf/latest/shelf/Request-class.html https://pub.dev/documentation/shelf/latest/shelf/Response-class.html

both subclass a hidden Message class. The members that are inherited from that class appear as inherited, but we'd like that to be an implementation detail.

image

kevmoo avatar Jun 10 '21 17:06 kevmoo

@kevmoo Hmm, this seems to be working as I had originally intended (documented as a member of the class Request / Response with no reference to Message, while still marked as inherited).

To clarify, we should document an inherited element from a private class/mixin as not inherited at all?

jcollins-g avatar Jun 10 '21 17:06 jcollins-g

@kevmoo Hmm, this seems to be working as I had originally intended (documented as a member of the class Request / Response with no reference to Message, while still marked as inherited).

To clarify, we should document an inherited element from a private class/mixin as not inherited at all?

My feeling: if I cannot see the class the member is coming from, it's not inherited. Happy to discuss. This is just my take.

kevmoo avatar Jun 10 '21 17:06 kevmoo

This seems reasonable.

jcollins-g avatar Jun 10 '21 17:06 jcollins-g