dart-lang
Fix dependency on discontinued js package
The package js, which build_runner has a dependency on, was marked discontinued with release 0.7.2 on Feb. 12, 2025. The recommendation is to use js_interop instead moving forward per https://pub.dev/packages/js.
This should have been completed in https://github.com/dart-lang/build/pull/3793
@jakemac53, that removed actual usage of js, but it's still listed as a dependency: https://github.com/dart-lang/build/blob/7dbcd8532f417c7f9c18b173a070deb104a5c21e/build_runner/pubspec.yaml#L34
And it looks like build_web_compilers still depends on it as well.
Weird, I didn't see any more diagnostics, but yeah any remaining usage should be removed
Oh you are saying it's an unused dependency that just didn't get cleaned up
Oh you are saying it's an unused dependency that just didn't get cleaned up
In build_runner, yes, in build_web_compilers, there's an actual use (but there's an ignore_deprecated_member_use, so that's probably why you didn't see diagnostics)
Here's build_web_compilers:
https://github.com/dart-lang/build/blob/7dbcd8532f417c7f9c18b173a070deb104a5c21e/build_web_compilers/web/stack_trace_mapper.dart#L27-L28
Yes, I added the ignore as it broke CI :)
I guess it's okay if I get to this in a week or two, nothing's on fire?
I don't depend on build_web_compilers, but can we at least remove the unused dependency on js in build_runner on Monday?
(It's not breaking me, it's just that it's a tiny, separate patch that I'm sure others will hit pretty soon. Enjoy your weekend!)
They'll just see a warning, I think? Or is there actual breakage?
Just a warning, but again, it's a one-line fix and I'm certain some people will read "deprecated" and freak out (see: npm ecosystem).
I'm in the middle of a huge refactoring, it's not straightforward to do a release right now. Hopefully this week.
Any updates on this @davidmorgan ?
The update (as far as I can tell) is that @davidmorgan's experiments are coming along well and if we keep being patient, we'll have a much faster build_runner pretty soon! (Is that accurate?)
Any updates on this @davidmorgan ?
The update (as far as I can tell) is that @davidmorgan's experiments are coming along well and if we keep being patient, we'll have a much faster build_runner pretty soon! (Is that accurate?)
That's the plan, yes :)
Sorry I let this slip, obviously "this week" didn't happen. But the refactoring is going well ... hopefully I can get a new release out in a week or two.