build icon indicating copy to clipboard operation
build copied to clipboard

Drop $web$ and $test$ placeholders

Open natebosch opened this issue 5 years ago • 5 comments

$package$ should be used instead.

natebosch avatar Dec 12 '19 16:12 natebosch

When that transition happens, please make sure to add appropriate documentation or changelog entries so that we have somewhere to look when migrating our builders. Thank you

daniel-v avatar Dec 09 '20 11:12 daniel-v

Yes we definitely will when we do drop these. You should be able to get ahead of this and migrate to $package$ at any time though, and if that causes a problem for you it would be good to know early as well (for us).

jakemac53 avatar Dec 09 '20 15:12 jakemac53

I'd love to give you feedback on it and willing to migrate all my builders to it as a test but I am stuck at step 1: I have no idea what $package$ means. Could you point me to the right place where I could gather some info on it?

daniel-v avatar Dec 09 '20 15:12 daniel-v

Are you familiar with $test$ and $web$? If so, $package$ is the same except that it lives at the root of the package, while those live under their corresponding subdirectories (test/$test$, web/$web$ etc).

jakemac53 avatar Dec 09 '20 15:12 jakemac53

Quick prototype shows, that our builder works with $package$ just as well as with $web$. Obviously, paths had to be updated, since assets are located 1 level deeper in the directory structure but other than that, it seems to be OK at first glance.

daniel-v avatar Dec 10 '20 16:12 daniel-v