build icon indicating copy to clipboard operation
build copied to clipboard

Remove serve handler from `build_runner`

Open natebosch opened this issue 5 years ago • 3 comments

Replaced by webdev serve which has it's own hot reloading handling.

We should be able to remove:

  • The serve command and all related code.
  • All code related to hot reloading.

natebosch avatar Apr 24 '19 21:04 natebosch

If/when the serve command is removed, will there still be a way to utilize --track-performance? Or is there another way to view the perf data after a build runs with that flag enabled?

evanweible-wf avatar May 21 '19 16:05 evanweible-wf

We'd implement some other mechanism for --track-performance.

natebosch avatar May 21 '19 16:05 natebosch

It was always a bit weird that you had to be in serve mode for that to work, and it has never worked with webdev or any other build daemon client I don't think, so it needs a revisit anyways :).

jakemac53 avatar May 21 '19 16:05 jakemac53