route.dart icon indicating copy to clipboard operation
route.dart copied to clipboard

Add method returning all sub-routes of a Route object

Open raptaml opened this issue 10 years ago • 5 comments

An easy way to get all sub-routes of a Route was missing. This PR adds it to abstract class Route and its implementation. Tests pass in current content-shell full-stable-45692.0.

Review on Reviewable

raptaml avatar Jun 02 '15 12:06 raptaml

You are right. Hope that fits.

raptaml avatar Jun 02 '15 14:06 raptaml

Also add the method to RouteHandle https://github.com/angular/route.dart/blob/master/lib/route_handle.dart

pavelgj avatar Jun 02 '15 14:06 pavelgj

Would you like to have RouteHandle return its route's subRoutes or throw "unsupported"? Think it should throw.

raptaml avatar Jun 02 '15 15:06 raptaml

It should return _route.subRoutes

pavelgj avatar Jun 02 '15 15:06 pavelgj

Hi, will this be released? And if so, when is ETA ? Thanks

raptaml avatar Oct 07 '15 14:10 raptaml