pub-dartlang icon indicating copy to clipboard operation
pub-dartlang copied to clipboard

pub.dartlang.org should more thoroughly validate packages

Open DartBot opened this issue 10 years ago • 15 comments

From @nex3 on September 12, 2012 01:05:22

Currently, pub.dartlang.org does very sparse validation on uploaded packages. It should also validate:

  • That the package name follows the naming conventions (valid Dart identifier, doesn't conflict with any reserved words, all lower case).
  • That the package description is non-empty.

Original issue: http://code.google.com/p/dart/issues/detail?id=5094

DartBot avatar Sep 29 '14 17:09 DartBot

From butler.matthew on September 14, 2012 17:49:48

If doing this, should pub make the same validation when using pub install/update?

Current pub validates that the name is exists but it does not appear to have constraints on what the name is. For instance can have capital letters, spaces, even reserved words (String).

DartBot avatar Sep 29 '14 17:09 DartBot

From @nex3 on September 14, 2012 18:35:30

I think we want to be somewhat more lenient on the install side to support Git repos that may not be entirely up-to-snuff.

DartBot avatar Sep 29 '14 17:09 DartBot

From butler.matthew on September 14, 2012 18:40:39

Sounds good to me. Also gives private repositories a little leeway as well. So long as it is well documented that the naming convention is enforced.

Thanks

DartBot avatar Sep 29 '14 17:09 DartBot

From @nex3 on November 29, 2012 19:20:16

See also issue 7045 .

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on December 12, 2012 16:08:49

Labels: -Milestone-M2 Milestone-M3

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on December 13, 2012 12:59:35

Labels: -Type-Defect Type-Enhancement

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on February 12, 2013 15:06:06

Labels: -Milestone-M3 Milestone-M4

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on April 18, 2013 11:00:35

Labels: -Milestone-M4 Milestone-M5

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on May 31, 2013 10:28:27

Labels: -Milestone-M5 Milestone-Later

DartBot avatar Sep 29 '14 17:09 DartBot

From @munificent on August 21, 2013 15:40:01

Labels: -Area-Pub Area-PubSite

DartBot avatar Sep 29 '14 17:09 DartBot

From [email protected] on January 28, 2014 01:19:24

I couldn't find a place where the package naming conventions are documented. http://stackoverflow.com/questions/21401244

DartBot avatar Sep 29 '14 17:09 DartBot

From @nex3 on January 28, 2014 16:38:28

I couldn't find a place where the package naming conventions are documented. http://stackoverflow.com/questions/21401244 This isn't the place for questions like that. I've answered it on the StackOverflow post, but in the future queries like that belong on the mailing list.

DartBot avatar Sep 29 '14 17:09 DartBot

From [email protected] on January 28, 2014 21:26:41

Thanks for the references in your SO answer. This was not meant as a question rather a hint that it isn't documented. I tried to find something but Google search didn't come up with useful results besides this issue.

DartBot avatar Sep 29 '14 17:09 DartBot

From @kasperl on July 10, 2014 03:22:17

Labels: -Milestone-Later Oldschool-Milestone-Later

DartBot avatar Sep 29 '14 17:09 DartBot

From @kasperl on August 04, 2014 00:42:31

Labels: -Oldschool-Milestone-Later

DartBot avatar Sep 29 '14 17:09 DartBot