di.dart icon indicating copy to clipboard operation
di.dart copied to clipboard

Published 20 hours ago • verified publisher icon dart-archive

Parameterized Test Failure #170

Open jrote1 opened this issue 11 years ago • 9 comments

Review on Reviewable

jrote1 avatar Aug 22 '14 09:08 jrote1

@vicb the pull request you requested

jrote1 avatar Aug 22 '14 13:08 jrote1

Thanks, that will help to get the problem fixed. Please fix the code style. If you haven't already done you need to sign the CLA https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#cla

vicb avatar Aug 22 '14 17:08 vicb

Sorted all the styling issues.

CLA already signed

jrote1 avatar Aug 22 '14 19:08 jrote1

Awesome, thanks

vicb avatar Aug 22 '14 19:08 vicb

Any progress on this?

jrote1 avatar Sep 05 '14 10:09 jrote1

I'm afraid there is no way to fix other than #106 but that implies to raise Dart req to 1.7+ (1.7 is not out yet, 1.6 has just been released). I would love to be proved wrong though.

vicb avatar Sep 05 '14 15:09 vicb

I have just started looking into it and have noticed that injector.get returns the correct but the test still fails which to me does not make any sense!

jrote1 avatar Sep 05 '14 19:09 jrote1

Any help is appreciated here. Remember to test both the Dart & JS versions.

vicb avatar Sep 05 '14 19:09 vicb

#170 Tag Issue

jrote1 avatar Oct 21 '14 20:10 jrote1