angular.dart icon indicating copy to clipboard operation
angular.dart copied to clipboard

Published 20 hours ago • verified publisher icon dart-archive

platform.js Shadow DOM shim should work with attribute selectors

Open jbdeboer opened this issue 10 years ago • 10 comments

e.g. a Component with the selector 'foo[bar]' will cause the Shadow DOM shim to fail.

This only effects browsers that need the shim.

jbdeboer avatar Jun 28 '14 00:06 jbdeboer

It can be fixed only after https://github.com/Polymer/platform-dev/issues/44.

vsavkin avatar Sep 01 '14 22:09 vsavkin

@vsavkin haven't you tried to fix the js and submit a PR ? What was the outcome ? I don't think the linked issue is clear enough. It should also state what we need. I don't think we need any selector as we could easily add a class or an attribute. I thought that the only problem was that the selector is set to the tag name which is not unique to a (angular) component ?

vicb avatar Sep 02 '14 01:09 vicb

@vicb I was going to, but it turned out to be a low-priority issue. So I did not do any work on it. I've updated the issue. Please check if it is clear now.

vsavkin avatar Sep 02 '14 12:09 vsavkin

@vsavkin If think the description is much better now - especially the second part which propose a solution. What about going even further and propose an API. Then we are sure that what gets implemented fit our needs.

vicb avatar Sep 04 '14 10:09 vicb

@vicb I've added an API proposal.

vsavkin avatar Sep 04 '14 12:09 vsavkin

@vsavkin :+1: Have you tried to contact the polymer team about that ? It would great to get their opinion about this and an ETA if they agree

vicb avatar Sep 04 '14 13:09 vicb

@vicb I haven't, but it is a good idea. I'll shoot them an email today.

vsavkin avatar Sep 04 '14 13:09 vsavkin

Hi,

Any progress on that issue.

The monkeysecurity raised an issue on Angular Dart UI:

WARNING: 2015-01-02 18:11:00.002: WARNING: Failed to set up Shadow DOM shim for pagination[page][total-items].
InvalidCharacterError: The string contains invalid characters. 'pagination[page][total-items]' is not a valid attribute name.

It would be nice to have any feedback from you.

akserg avatar Jan 06 '15 10:01 akserg

@akserg It looks like the issue has not been fixed in Platform.js. So it is not fixed in AngularDadrt either (cause we are emulating their approach). You can, however, define your own shim (as shown here https://github.com/angular/angular.dart/wiki/CSS-Shim), where you can, for instance, take the element part of the selector and use it for shimming.

vsavkin avatar Jan 06 '15 16:01 vsavkin

https://github.com/Polymer/platform-dev/issues/44 has been moved to https://github.com/webcomponents/webcomponentsjs/issues/28 (former repo is deprecated)

vicb avatar Jan 23 '15 14:01 vicb