Kyle Daruwalla

Indeed that error should be caught not thrown by the standard validation phase, but I can't see why the current code doesn't do that. Let me try and reproduce.

Ah I see the issue is that early stopping throws a `CancelFittingException` but the epoch and step handlers only catch `CancelEpochException`/`CancelStepException`. See [here](https://github.com/FluxML/FluxTraining.jl/blob/8d24b5693b82b3c3e5a343c00662fc52a27f1952/src/training.jl#L91-L144). I guess the appropriate fix would be...

That's expected. Your new training loop must catch the fitting exception, since it is taking over the role of the outer loop from the package. Exceptions that are caught at...

It seems from the failing tests that this functionality was intended. I guess the desired usage was that you should catch the `CancelFittingException` in your user code instead within the...

It sounds like we need to distinguish early stopping (benign) from NaN loss (bad). I would say we create a `EarlyStoppingException` type. We throw this from the early stopping callback...

Looks like a deployment issue. The `gh-pages` branch probably needs to be manually cleaned up.

Could we just ignore the `do` keyword? Anytime a do-block is used, the user could have provided a defined function instead of an anonymous one. In the case of a...

True, Zygote should support the try/catch handling, but I suggested opening an issue here because the source for ProgressMeter.jl [specifically mentions not descending inner function returns](https://github.com/timholy/ProgressMeter.jl/blob/1aba22127a903f60a034fbb2fecb8ca6f0b499b0/src/ProgressMeter.jl#L531).

I do think DocumenterVitepress version seems prettier, but I share the concerns about readability at the cost of visual appeal. Here's a comparison between the current PR, the PR without...

Without speaking directly to MLJFlux, this is how `eachbatch` from MLDataPattern.jl works. If you consider the "data iterator" returned by `itr = eachbatch(data, batch_size)`, then `itr[1]` (i.e. the first observation...