Darron Schall
Darron Schall
I looked at the failing test runs, but I can't reproduce. It doesn't seem to be related to this PR: ``` NameError: uninitialized constant Rack::Request Did you mean? Rack::MockRequest ```...
Thanks for the tip @danielmorrison. I added [e589253](https://github.com/twitchtv/twirp-ruby/pull/91/commits/e5892539dd41987b744a46c859ea9c66842e5b94) to green up the build.
I saw rack was added/merged via #94 to fix the build errors. I'll rebase this and remove my rack fixup commit since it's not necessary anymore.
For what it's worth, it doesn't look like iOS 17 adds callouts to the SwiftUI Map component based on the initial beta documentation at https://developer.apple.com/documentation/mapkit/mapkit_for_swiftui The proposed solution at https://github.com/pauljohanneskraft/Map/pull/46#issuecomment-1529020296...
I am seeing this issue as well. I wanted to share my workaround in the event someone else is running in to it. I am running `mogenerator` (1.31) with this...
I poked around with this in https://github.com/mastodon/mastodon/compare/main...darronschall:mastodon:panko-benchmark-tag-serializer I focused on the `TagSerializer` without a `current_user` (thus omitting the `"following"` flag). Running `rspec ./spec/serializers/tag_serializer_spec.rb` with my branch checked out shows the...
Quick addendum. I added another benchmark to use Panko's [`serialize_to_json`](https://github.com/panko-serializer/panko_serializer/blob/3378e6a136c0ca00b71a2edd95319b2f9ec9f5b4/lib/panko/serializer.rb#L133) which uses `Oj::StringWriter` internally. This version is the fastest using my branch (repeating the tag serializing 25 times in the...
This is possibly an unrelated bug, but might be worth exploring while you're switching up rubocop linting. When I run `bundle exec rubocop` locally, my results differ than the lint-ruby...
@arthurnn Should I also update names in `test` to be well-named, like #91 did in 8125bf04d94a25aeaf28fe4fbe515eb92ff7c072? Separate PR maybe?
@arthurnn Just wanted to check in since it's been a few months. Have you been able to take a look at this yet? No rush, and no pressure. It'd be...