Darren Kelly

Results 19 comments of Darren Kelly

> > Can we also add ABI support, so we're fully compatible with current vechain signers? > > I was somehow expecting this to happen already automatically in the background...

> @darrenvechain This looks like a good spot to add it and having it enabled for all calls by default: > > https://github.com/vechain/vechain-sdk-js/blob/b27bb34a6b5e6af44daa8362c79c07e06d6cd091/packages/core/src/clause/clause.ts#L46-L57 > > Is it possible that the...

IMO acould approach could be some optional options when building clauses: ```typescript type ClauseOptions = { ...existing, comment?: string includeAbi?: boolean } ```

@victhorbi @Valazan I have a branch here: https://github.com/vechain/vechain-dapp-kit/tree/initial-sdk-integration It's not ready IMO because this doesn't integrate nicely: https://github.com/vechain/vechain-dapp-kit/compare/main...initial-sdk-integration#diff-a999ba64cb656fd4b2ee3ad5af2760947bee57b113a71b38db801621477e8073R64

@claytonneal I believe there is a validation in the validate.ts file: https://github.com/vechain/app-hub/blob/master/scripts/validate.ts#L110

@otherview does this persist all requests indefinitely ? Maybe we should have a daily cleanup action that clears log files older than X time? Or once it's using more the...

> > @otherview does this persist all requests indefinitely ? Maybe we should have a daily cleanup action that clears log files older than X time? Or once it's using...

~~@otherview IMO we probably don't need to log requests to the console, as it would make debugging quite difficult in nodes with a lot a traffic~~ Never mind, my mistake,...

Hey @libotony I made 2 commits to resolve PR comments