duplicate-package-checker-webpack-plugin
duplicate-package-checker-webpack-plugin copied to clipboard
darrenscerri
Make changes for Webpack 5
This will address the deprecation warning that comes with Webpack 5. Should resolve #42
It seems like the UTs fail in master on Windows. Would be good to confirm if the tests pass in Mac/Linux before and after this change.
I'd like to have this released and I can help you with linux test if you'll hold my hand with the process…
I'd like to have this released and I can help you with linux test if you'll hold my hand with the process…
Thanks for the offer! I'm not a maintainer of the project, so I won't be able to merge the PR. But the thing I'd like to confirm here is that the tests pass in master and in this PR branch, as they fail in both places on my windows machine. I just cloned the repo, ran npm install, npm run build, and npm run test. It seems the paths being checked in the tests are Unix paths, but I don't have a Unix machine.
Well ... I'm not sure if this is an OK run, but that's what I get from npm run test both on your version & master…
λ npm run test
> [email protected] test /home/pepa/dev/duplicate-package-checker-webpack-plugin
> jest test/**/*.test.js --runInBand
(yep, just 3 empty lines)
FWIW we maintain a fork of this project with webpack 5 support. https://www.npmjs.com/package/@cerner/duplicate-package-checker-webpack-plugin
