csharp-sparkpost
csharp-sparkpost copied to clipboard
darrencauthon
Replace Message Events API with the new Events API
@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes?
Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open.
If you'd like help just holler and I'd be happy to help plug them in.
@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes?
Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open.
If you'd like help just holler and I'd be happy to help plug them in.
We're using it in our projects and so far we haven't encountered any issues yet based on our use cases. I'll add the new MessageEventTypes tonight. Thanks for letting me know.
@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes? Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open. If you'd like help just holler and I'd be happy to help plug them in.
We're using it in our projects and so far we haven't encountered any issues yet based on our use cases. I'll add the new MessageEventTypes tonight. Thanks for letting me know.
Awesome, thanks!
I noticed there is also a value missing in the BounceClass enum (26, smart send suppression). I don't know how new that is, I hadn't noticed it in the API documentation until this morning.
@zythra I've added the missing MessageEventType and BouncClass enum values
Great! Thank you, @jomargon! Looks like pagination support is not implemented. MessageEventsQuery.Page=10 (/api/v1/events/message?page=10) doesn't work any more (not supported). https://developers.sparkpost.com/api/events/#events-pagination We should use ListMessageEventsResponse.Links.Next URL to request next page, but I can't find a way to create request using custom URL. I will implement it and publish soon.
I have implemented custom request URL support for Message Events API to be used for pagination. Here is the pull request to ISSUE-182 branch: https://github.com/jomargon/csharp-sparkpost/pull/1
