csharp-sparkpost icon indicating copy to clipboard operation
csharp-sparkpost copied to clipboard

Request: Add TargetLinkUrl to MessageEvent

Open zythra opened this issue 8 years ago • 4 comments

Can TargetLinkUrl be added to MessageEvent please? I've added it in a cloned repo, but the change is so small I don't know that it's worth creating a pull request for it. It was as simple as adding the property to MessageEvent and adding the mapping "TargetLinkUrl = result.target_link_url" in the ConvertResultsToAListOfMessageEvents() method in the MessageEvents class.

Thanks!

zythra avatar Sep 22 '17 18:09 zythra

Create a Pull Request so this can be implemented

Richard-West avatar Oct 11 '17 21:10 Richard-West

@Richard-West Funny you should mention this today as I was just thinking this morning I'd just go ahead and do it. Is this something you're after as well or were you just giving me a little push? ;)

zythra avatar Oct 11 '17 21:10 zythra

Pull request submitted.

https://github.com/darrencauthon/csharp-sparkpost/pull/153

zythra avatar Oct 11 '17 22:10 zythra

We were looking for this same functionality earlier today!

Richard West


From: zythra [email protected] Sent: Wednesday, October 11, 2017 5:54:46 PM To: darrencauthon/csharp-sparkpost Cc: Richard West; Mention Subject: Re: [darrencauthon/csharp-sparkpost] Request: Add TargetLinkUrl to MessageEvent (#152)

@Richard-Westhttps://github.com/richard-west Funny you should mention this today as I was just thinking this morning I'd just go ahead and do it. Is this something you're after as well or were you just giving me a little push? ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/darrencauthon/csharp-sparkpost/issues/152#issuecomment-335960456, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD_YW9XIICThbBDAGsPICXgaKuUHMVrgks5srTkmgaJpZM4PhFDN.

Richard-West avatar Oct 11 '17 22:10 Richard-West