Darrel

Results 511 comments of Darrel

Thank you for raising this issue. We would really like to find a good resolution to this. You could argue that any deserializer could read the JSON.NET annotations on the...

@jdelforno If you are looking for OpenAPI documents that will work with AutoREST, we have these here https://github.com/microsoftgraph/msgraph-sdk-powershell/tree/dev/openApiDocs that we use for the AutoREST PowerShell generation. We can generate V2...

From what I can see, the schema of the request body is getting lost. It seems to be lost on writing of both v3 and V2, so the issue is...

~~The OpenAPIReferenceResolver visitor~~ https://github.com/microsoft/OpenAPI.NET/blob/vnext/src/Microsoft.OpenApi/Services/OpenApiReferenceResolver.cs ~~is not visiting Schemas in request bodies so the~~ $ref ~~is not getting resolved. On the surface this looks like an easy fix.~~ Well, that's not...

@tomlm That one was a little harder to find than I expected. Here's the snippet of OpenAPI that is relevant. ```json "/drives/{drive}/files/{file}/tables/{table}/items/{id}": { "patch": { "tags": [ "ExcelOnlineTableData" ], "summary":...

Perhaps we should report an error if consumes is empty but there is a body parameter. This is very much a v2 problem because structurally you can't make this error...

We will probably have to make some changes to the OpenApiSchema model as we implement OpenAPI 3.1 support and support for JSON Schema 2020-12 draft. We can consider an interface...

This issue https://github.com/microsoftgraph/msgraph-metadata/issues/124 is dependent on overlays.

I don't feel strongly about whether we should create a new project or not. However, I suspect we will re-use the OpenApiAny types and the ParseNode classes in the reader,...

Upon further discussion we believe that accepting strongly typed OpenAPI objects is not going to work. Instead we should limit the update property to only accept OpenApiArray, OpenApiObject and OpenApiPrimitive....