Darran Lofthouse
Darran Lofthouse
One change I could make to this PR is to cache the SAM instance in the AuthConfigProvider instance, we already know that Soteria does not make use of any of...
As I say the gap in the calls is the server integration is choosing to request a new ServerAuthConfig instance so it can provide a new CallbackHandler instance into the...
Looks like a conflict specific to master so will adjust that separately. I have just pushed another change to the branch, this changes the logic to cache the ServerAuthModule instance...
That last push should clean up the merge conflict.
BTW off topic - these travis failures should be resolvable by switching to openjdk8 instead of oraclejdk8 we saw this on some of our repos. I can submit a PR...
@jamezp Could you please provide your update in a review, this shows as approved in the GitHub UI but I think with your comment it should either be "Changed Requested"...
What happens if this attribute is set to something else? A change such as this risks preventing boot from succeeding using an existing configuration, if that existing configuration would also...
> But that would mean I have to include the new parser as well (and now we're cascading into including most of the commit); I tried checking how it was...
Hi @michpetrov unfortunately no that split still does not work, I can not see in the GitHub UI the changes made to the schema after it was bumped.
@michpetrov yes bump the version first without making any changes so the files are just a copy of the last version with things like the version updated so they are...